Skip to content

fix(accessibility): fix some accessibility issues#2450

Merged
miaulalala merged 2 commits intomasterfrom
fix/noid/accessibility-issues
Mar 18, 2026
Merged

fix(accessibility): fix some accessibility issues#2450
miaulalala merged 2 commits intomasterfrom
fix/noid/accessibility-issues

Conversation

@miaulalala
Copy link
Collaborator

No description provided.

@miaulalala miaulalala added this to the Nextcloud 34 milestone Mar 12, 2026
@miaulalala miaulalala self-assigned this Mar 12, 2026
Copilot AI review requested due to automatic review settings March 12, 2026 11:57
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nents/richArgumentsTypes/OpenGraphRichArgument.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

This comment was marked as outdated.

@miaulalala
Copy link
Collaborator Author

/compile amend /

@nextcloud-command nextcloud-command force-pushed the fix/noid/accessibility-issues branch from 35e6401 to 1e69519 Compare March 12, 2026 12:02
@cypress
Copy link

cypress bot commented Mar 12, 2026

Activity    Run #3482

Run Properties:  status check passed Passed #3482  •  git commit 316a533d21: fix(accessibility): fix some accessibility issues
Project Activity
Branch Review fix/noid/accessibility-issues
Run status status check passed Passed #3482
Run duration 02m 04s
Commit git commit 316a533d21: fix(accessibility): fix some accessibility issues
Committer Anna
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 9
View all changes introduced in this branch ↗︎

@miaulalala miaulalala force-pushed the fix/noid/accessibility-issues branch from 1e69519 to b52ef20 Compare March 12, 2026 12:40
@miaulalala miaulalala requested a review from Copilot March 12, 2026 12:40

This comment was marked as outdated.

@miaulalala
Copy link
Collaborator Author

/compile amend

@nextcloud-command nextcloud-command force-pushed the fix/noid/accessibility-issues branch from b52ef20 to 5646c95 Compare March 12, 2026 13:04
@miaulalala miaulalala requested a review from Copilot March 12, 2026 14:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 27 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@miaulalala miaulalala force-pushed the fix/noid/accessibility-issues branch from 5646c95 to ce36818 Compare March 18, 2026 12:31
@miaulalala
Copy link
Collaborator Author

/compile amend

Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/noid/accessibility-issues branch from ce36818 to 3e078ea Compare March 18, 2026 12:32
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala merged commit aae4c99 into master Mar 18, 2026
53 checks passed
@miaulalala miaulalala deleted the fix/noid/accessibility-issues branch March 18, 2026 13:05
@miaulalala
Copy link
Collaborator Author

/backport to stable33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants